gabriel / muse public
refactor tests task/hashlib-cleanup #1 / 1
AI Agent gabriel · 133 days ago · May 5, 2026 · Diff

refactor(tests): eliminate remaining hashlib wrappers; fix genesis docstrings

- Replace long_id(hashlib.sha256(data).hexdigest()) with f'sha256:{hashlib.sha256(data).hexdigest()}' in test_core_types.py (blob_id and hash_file test assertions — keeps actual verification) - Replace long_id(hashlib.sha256(data).hexdigest()) with blob_id(data) in test_public_key_fingerprint.py; remove unused long_id and hashlib imports - Inline blob_id + split_id in shelf-path helpers across test_cmd_gc_hardening, test_gc_full, test_object_store_write_taxonomy, test_core_gc, test_gc_path_helpers_and_remote_refs; remove import hashlib from each - test_hash_object_canonical: bare_hex = split_id(blob_id(content))[1]; remove hashlib - test_security_object_store_poisoning: remove _sha256 wrapper; inline blob_id at ~10 sites; replace streaming sha256 block with hash_file(); remove hashlib - test_code_migrate: _object_flat/_object_canonical use blob_id+split_id; remove hashlib

sha256:3fb803bba4132194e20e5bd58d61330d939d141b441f657239c021e9f2181ce0 sha
sha256:eb54833b6bea236ce48748dd9a20f42e17bca34a1c0f344201efce167a8cfab8 parent
+6 ~73 −10 symbols
sha256:e6f9dc0d23d6e6b1ee369ddfeab21c78e4ebd2a52e9edc2c268ec7d12bbeb1a2 snapshot
+6
symbols added
~73
symbols modified
−10
symbols removed
0
dead code introduced
Semantic Changes 89 symbols
~ tests/test_cmd_gc_hardening.py .py 1 symbol removed, 1 symbol modified
− hashlib import import hashlib L54–54
~ _write_shelf_entry
~ tests/test_code_migrate.py .py 1 symbol added, 1 symbol removed, 6 symbols modified
− hashlib import import hashlib L33–33
+ split_id import import split_id L42–42
~ TestObjectPathMigration
~ test_flat_dir_removed_after_move
~ _object_canonical
~ _object_flat
~ blob_id
~ long_id
~ tests/test_core_gc.py .py 1 symbol added, 1 symbol removed, 3 symbols modified
− hashlib import import hashlib L5–5
+ split_id import import split_id L15–15
~ _write_shelf_entry
~ Manifest
~ blob_id
~ tests/test_core_types.py .py 5 symbols modified
~ TestBlobId
~ test_empty_bytes
~ test_matches_manual_sha256
~ TestHashFile
~ test_matches_manual_sha256
~ tests/test_gc_full.py .py 1 symbol removed, 1 symbol modified
− hashlib import import hashlib L65–65
~ _write_shelf_entry
~ tests/test_gc_path_helpers_and_remote_refs.py .py 1 symbol added, 5 symbols modified
+ split_id import import split_id L43–43
~ TestPathHelpers
~ test_shelf_dir_path_is_canonical
~ blob_id
~ fake_id
~ long_id
~ tests/test_hash_object_canonical.py .py 1 symbol added, 1 symbol removed, 3 symbols modified
− hashlib import import hashlib L19–19
+ split_id import import split_id L25–25
~ TestCanonicalPrefix
~ test_no_bare_hex_in_json_output
~ blob_id
~ tests/test_object_store_write_taxonomy.py .py 1 symbol removed, 3 symbols modified
− hashlib import import hashlib L41–41
~ TestWriteObject
~ test_rejects_bare_hex_object_id
~ _write_shelf_entry
~ tests/test_public_key_fingerprint.py .py 1 symbol added, 2 symbols removed, 4 symbols modified
− hashlib import import hashlib L9–9
− long_id import import long_id L14–14
+ blob_id import import blob_id L12–12
~ TestPublicKeyFingerprintCanonical
~ test_correct_sha256_of_input
~ test_empty_bytes
~ test_known_zero_key
~ tests/test_security_object_store_poisoning.py .py 1 symbol added, 2 symbols removed, 42 symbols modified
− _sha256 function function _sha256 L50–51
− hashlib import import hashlib L21–21
+ hash_file import import hash_file L41–41
~ TestApplyPackBomb
~ _build_pack
~ test_oversized_object_in_pack_is_skipped
~ TestApplyPackDeduplication
~ test_duplicate_object_ids_not_hashed_twice
~ test_duplicate_then_different_both_processed
~ TestApplyPackMalformedEntries
~ test_malformed_object_entry_does_not_abort_pack
~ TestCallsiteIntegrity
~ test_hash_object_file_derives_id_from_file_content
~ test_hash_object_stdin_derives_id_from_content
~ test_unpack_objects_hash_mismatch_rejected
~ TestConcurrentPoisoning
~ test_concurrent_hash_mismatch_attempts_do_not_corrupt
~ test_concurrent_writes_of_same_object_idempotent
~ TestHashMismatch
~ test_empty_object_valid
~ test_write_object_correct_content_succeeds
~ test_write_object_from_path_correct_id_succeeds
~ test_write_object_from_path_wrong_id_raises
~ test_write_object_wrong_content_raises
~ TestObjectSizeCap
~ test_exactly_at_limit_is_rejected
~ test_just_under_limit_succeeds
~ test_oversized_content_rejected_at_write
~ test_write_object_from_path_oversized_raises
~ TestReadObjectIntegrity
~ test_read_absent_object_returns_none
~ TestRestoreObjectIntegrity
~ test_restore_missing_object_returns_false
~ TestSHA256ThreatModel
~ test_sha256_preimage_resistance_documented
~ test_write_then_read_roundtrip_preserves_content
~ TestStress
~ test_10k_duplicate_ids_deduplicated
~ test_10k_object_pack_within_budget
~ test_idempotent_10k_pack_fast
~ _stored_object
~ Manifest
~ blob_id
~ long_id
~ now_utc_iso
← Older Oldest on task/hashlib-cleanup
All commits
Newer → Latest on task/hashlib-cleanup

0 comments

No comments yet. Be the first to start the discussion.

To add a comment, use the Muse CLI: muse hub commit comment sha256:3fb803bba4132194e20e5bd58d61330d939d141b441f657239c021e9f2181ce0 --body "your comment"