gabriel / muse public
refactor BREAKING bridge task/bridge-issue14-sweep #1 / 1
AI Agent gabriel · 113 days ago · May 22, 2026 · Diff

refactor(bridge): comprehensive spec sweep — close all issue #14 gaps

Fixes all spec violations found in post-completion sweep:

bridge.py — 375 → 74 lines, zero re-exports, argparse-only - Move _register_git_import, _register_git_export, _register_git_status to their canonical submodules (importer, exporter, status) - bridge.py now delegates to _register_*_parser() helpers and imports nothing from the domain layer

muse/core/bridge/__init__.py — add full public API re-export - All symbols tests might import from the package now accessible via muse.core.bridge directly (per Phase 8 spec)

git_primitives.py — fix circular import violation - FileDiffTree = dict[str, str | None] defined here, not in state.py - state.py no longer carries a type that belongs to the git layer - Upholds 'git_primitives has no Muse domain knowledge' invariant

All test imports updated: zero imports from muse.cli.commands.bridge - Every test now imports from the canonical muse.core.bridge.* path - No backward-compat shims; the old path is the thin CLI shell only

277/277 tests pass.

sha256:51116ec824246acde6abf729e6ba854c223dc5173eff31a645520208023b0652 sha
sha256:702e85ec851c9d2efd9cfcc2ea50ec816a362275e4ba8e8ef0bd89a39fea5bb8 parent
+35 ~121 −31 symbols
sha256:719041cabcaf89a76d45aea88d6c44564c1064167325c5f3af1b8abdb5524b79 snapshot
+35
symbols added
~121
symbols modified
−31
symbols removed
0
dead code introduced
Semantic Changes 187 symbols
~ muse/cli/commands/bridge.py .py 3 symbols added, 29 symbols removed, 1 symbol modified
− _register_git_export function function _register_git_export L236–348
− _register_git_import function function _register_git_import L88–234
− _register_git_status function function _register_git_status L350–375
− AttributionMapper import import AttributionMapper L42–42
− BridgeHook import import BridgeHook L57–57
− BridgeHooks import import BridgeHooks L57–57
− BridgeState import import BridgeState L59–59
− GitExporter import import GitExporter L41–41
− _CatFile import import _CatFile L42–42
− _batch_commit_log import import _batch_commit_log L42–42
− _git import import _git L42–42
− _replay_branch import import _replay_branch L58–58
− _replay_commit import import _replay_commit L58–58
− _should_exclude import import _should_exclude L42–42
− _validate_git_branch_name import import _validate_git_branch_name L42–42
− _validate_git_sha import import _validate_git_sha L42–42
− _watch_loop import import _watch_loop L41–41
− export_harmony_to_rerere import import export_harmony_to_rerere L51–51
− export_shelves_to_stash import import export_shelves_to_stash L51–51
− import_rerere_to_harmony import import import_rerere_to_harmony L51–51
− import_stashes_to_shelf import import import_stashes_to_shelf L51–51 → moved to muse/core/bridge/__init__.py
− load_bridge_hooks import import load_bridge_hooks L57–57
− read_bridge_state import import read_bridge_state L59–59
− run_git_export import import run_git_export L41–41 → moved to muse/core/bridge/__init__.py
− run_git_import import import run_git_import L58–58 → moved to muse/core/bridge/__init__.py
− run_git_status import import run_git_status L60–60 → moved to muse/core/bridge/__init__.py
− run_hook import import run_hook L57–57
− run_hooks import import run_hooks L57–57 → moved to muse/core/bridge/__init__.py
− write_bridge_state import import write_bridge_state L59–59 → moved to muse/core/bridge/__init__.py
+ _register_git_export_parser import import _register_git_export_parser L50–50
+ _register_git_import_parser import import _register_git_import_parser L51–51
+ _register_git_status_parser import import _register_git_status_parser L52–52
~ register
~ muse/core/bridge/__init__.py .py 28 symbols added
+ __all__ variable variable __all__ L33–68
+ AttributionMapper import import AttributionMapper L12–12
+ BridgeHook import import BridgeHook L28–28
+ BridgeHooks import import BridgeHooks L28–28
+ BridgeState import import BridgeState L30–30
+ FileDiffTree import import FileDiffTree L12–12
+ GitExporter import import GitExporter L11–11
+ _CatFile import import _CatFile L12–12
+ _batch_commit_log import import _batch_commit_log L12–12
+ _git import import _git L12–12
+ _replay_branch import import _replay_branch L29–29
+ _replay_commit import import _replay_commit L29–29
+ _should_exclude import import _should_exclude L12–12
+ _validate_git_branch_name import import _validate_git_branch_name L12–12
+ _validate_git_sha import import _validate_git_sha L12–12
+ _watch_loop import import _watch_loop L11–11
+ export_harmony_to_rerere import import export_harmony_to_rerere L22–22
+ export_shelves_to_stash import import export_shelves_to_stash L22–22
+ import_rerere_to_harmony import import import_rerere_to_harmony L22–22
+ import_stashes_to_shelf import import import_stashes_to_shelf L22–22 ← moved from muse/cli/commands/bridge.py
+ load_bridge_hooks import import load_bridge_hooks L28–28
+ read_bridge_state import import read_bridge_state L30–30
+ run_git_export import import run_git_export L11–11 ← moved from muse/cli/commands/bridge.py
+ run_git_import import import run_git_import L29–29 ← moved from muse/cli/commands/bridge.py
+ run_git_status import import run_git_status L31–31 ← moved from muse/cli/commands/bridge.py
+ run_hook import import run_hook L28–28
+ run_hooks import import run_hooks L28–28 ← moved from muse/cli/commands/bridge.py
+ write_bridge_state import import write_bridge_state L30–30 ← moved from muse/cli/commands/bridge.py
~ muse/core/bridge/exporter.py .py 1 symbol added
+ _register_git_export_parser function function _register_git_export_parser L541–656
~ muse/core/bridge/git_primitives.py .py 1 symbol added, 1 symbol removed
− FileDiffTree import import FileDiffTree L32–32
+ FileDiffTree variable variable FileDiffTree L39–39 ← moved from muse/core/bridge/state.py
~ muse/core/bridge/importer.py .py 1 symbol added
+ _register_git_import_parser function function _register_git_import_parser L587–736
~ muse/core/bridge/state.py .py 1 symbol removed
− FileDiffTree variable variable FileDiffTree L27–27 → moved to muse/core/bridge/git_primitives.py
~ muse/core/bridge/status.py .py 1 symbol added
+ _register_git_status_parser function function _register_git_status_parser L236–264
~ tests/test_bridge_git_export.py .py 20 symbols modified
~ TestDataIntegrity
~ test_bridge_state_git_sha_matches_git_log
~ test_muse_commit_id_in_json_output_matches_bridge_state
~ TestDocstrings
~ test_git_exporter_has_class_docstring
~ test_run_git_export_has_docstring_mentioning_ci
~ test_sync_to_git_has_docstring
~ TestFixFileModesShebang
~ _build_exporter
~ TestHasShebang
~ test_bash_shebang
~ test_empty_file_no_shebang
~ test_node_shebang
~ test_nonexistent_file_returns_false
~ test_one_byte_file_no_shebang
~ test_plain_text_no_shebang
~ test_python_shebang_no_env
~ test_shebang_after_leading_whitespace_is_not_shebang
~ TestRoundTrip
~ test_bridge_state_last_export_written
~ tests/test_bridge_git_import.py .py 16 symbols modified
~ TestDocstrings
~ test_attribution_mapper_has_docstring
~ test_batch_commit_log_has_docstring
~ test_cat_file_has_docstring
~ test_replay_branch_has_docstring
~ test_replay_commit_has_docstring
~ TestSchemaFlags
~ test_default_excludes_cover_git_dir
~ test_default_excludes_cover_node_modules
~ test_default_excludes_cover_pyc
~ test_default_excludes_cover_venv
~ test_non_excluded_path
~ TestSecurity
~ test_attribution_map_control_chars_rejected
~ TestStress
~ test_cat_file_stays_alive
~ tests/test_bridge_git_status.py .py 2 symbols modified
~ _write_bridge_state
~ BridgeState
~ tests/test_bridge_harmony_shelf.py .py 23 symbols modified
~ TestExportHarmonyToRerere
~ test_export_harmony_dry_run_writes_nothing
~ test_export_harmony_high_confidence_exported
~ test_export_harmony_human_verified_exported_regardless_of_confidence
~ test_export_harmony_low_confidence_skipped
~ test_export_harmony_no_patterns_returns_zero
~ TestExportShelvesToStash
~ test_export_one_shelf_creates_git_stash
~ test_export_shelves_dry_run_writes_nothing
~ test_export_shelves_no_entries_returns_zero
~ TestImportRerereToHarmony
~ test_import_rerere_custom_confidence
~ test_import_rerere_dry_run_writes_nothing
~ test_import_rerere_empty_rr_cache_returns_zero
~ test_import_rerere_idempotent
~ test_import_rerere_imports_one_entry
~ test_import_rerere_missing_postimage_skipped
~ test_import_rerere_missing_rr_cache_raises
~ TestImportStashesToShelf
~ test_import_one_stash_creates_shelf_entry
~ test_import_stash_dry_run_writes_nothing
~ test_import_stashes_idempotent
~ test_import_stashes_no_stashes_returns_zero
~ tests/test_bridge_hooks.py .py 28 symbols modified
~ TestGitExportHookIntegration
~ test_blocking_pre_hook_failure_aborts_export
~ test_env_vars_injected_into_hooks
~ test_no_hooks_file_export_runs_normally
~ test_post_bridge_hooks_run_after_commit
~ test_post_bridge_hooks_run_in_git_dir
~ test_pre_bridge_hooks_run_before_sync
~ test_pre_bridge_hooks_run_in_muse_root
~ TestLoadBridgeHooks
~ test_invalid_on_fail_value_raises_user_error
~ test_invalid_toml_raises_user_error
~ test_loads_post_bridge_hooks
~ test_loads_pre_bridge_hooks
~ test_missing_run_field_raises_user_error
~ test_returns_empty_hooks_when_file_missing
~ test_returns_empty_sections_when_section_missing
~ TestRunHook
~ test_block_hook_raises_on_nonzero_exit
~ test_hook_injects_env_vars
~ test_hook_runs_in_given_cwd
~ test_successful_hook_does_not_raise
~ test_warn_hook_does_not_raise_on_nonzero_exit
~ TestRunHooks
~ test_block_failure_stops_subsequent_hooks
~ test_empty_hook_list_is_a_noop
~ test_runs_all_hooks_in_order
~ test_warn_failure_continues_to_next_hook
~ BridgeHook
~ tests/test_bridge_phase1.py .py 8 symbols modified
~ TestBridgeStateSecurity
~ test_read_state_is_always_inside_muse
~ TestBridgeStateTypedDict
~ test_import_and_instantiate
~ test_muse_commit_id_is_prefixed
~ _read_bs
~ _write_bs
~ BridgeState
~ tests/test_bridge_security.py .py 15 symbols modified
~ TestAttributionMapControlCharsRejected
~ test_attribution_map_control_chars_rejected
~ test_attribution_map_control_chars_stripped
~ test_attribution_map_missing_email_gives_synthetic_handle
~ TestCatFileRejectsInvalidSha
~ test_catfile_accepts_valid_sha
~ test_catfile_rejects_invalid_sha
~ test_catfile_rejects_sha_with_injection
~ test_catfile_rejects_short_sha
~ TestCommitMessageTemplateUsesDotFormat
~ test_commit_message_format_call_is_present
~ TestValidateGitBranchName
~ _fn
~ TestValidateGitSha
~ _fn
~ tests/test_bridge_watch.py .py 8 symbols modified
~ TestWatchCallsExportOnChange
~ test_watch_calls_export_on_change
~ test_watch_no_export_when_head_unchanged
~ TestWatchDetectsHeadChange
~ test_watch_detects_head_change
~ TestWatchEmitsPollEvent
~ test_watch_emits_poll_event
~ test_watch_poll_event_has_required_keys
← Older Oldest on task/bridge-issue14-sweep
All commits
Newer → Latest on task/bridge-issue14-sweep

0 comments

No comments yet. Be the first to start the discussion.

To add a comment, use the Muse CLI: muse hub commit comment sha256:51116ec824246acde6abf729e6ba854c223dc5173eff31a645520208023b0652 --body "your comment"