gabriel / muse public
fix tests task/fix-zip-slip-test-delta-format #1 / 1
AI Agent gabriel · 118 days ago · May 13, 2026 · Diff

fix(tests): update TestPackZipSlip bundles to use SnapshotDeltaDict format

apply_mpack/_apply_snapshot_deltas expects SnapshotDeltaDict (delta_add key). The test helper _minimal_bundle and the manually-crafted invalid-OID bundle were building SnapshotDict (manifest key), causing the delta integrity check to fail before any path/OID validation was exercised.

Update both sites to SnapshotDeltaDict so the security validation code paths (validate_workspace_path, compute_snapshot_id rejection) are reached.

sha256:54a805404d0712cccee5d7488e409f0deeac4c7c0359df984d3ed878fa19196c sha
sha256:b8a9d02470ceeb56c636e7b4b5b2a61613f19f15aad89dbff8d83424c47d63d5 parent
+1 ~9 −1 symbols
sha256:309f842291622590bd6a195abc63d5e25739e82405b28c28bc01c43c2031883a snapshot
+1
symbol added
~9
symbols modified
−1
symbol removed
0
dead code introduced
Semantic Changes 11 symbols
~ tests/test_security_path_traversal.py .py 1 symbol added, 1 symbol removed, 9 symbols modified
− SnapshotDict import import SnapshotDict L40–40
+ SnapshotDeltaDict import import SnapshotDeltaDict L38–38
~ TestPackZipSlip
~ _minimal_bundle
~ test_invalid_object_id_in_manifest_rejected
~ CommitRecord
~ MPackBundle
~ SnapshotRecord
~ apply_mpack
~ write_commit
~ write_snapshot
← Older Oldest on task/fix-zip-slip-test-delta-format
All commits
Newer → Latest on task/fix-zip-slip-test-delta-format

0 comments

No comments yet. Be the first to start the discussion.

To add a comment, use the Muse CLI: muse hub commit comment sha256:54a805404d0712cccee5d7488e409f0deeac4c7c0359df984d3ed878fa19196c --body "your comment"