gabriel / muse public
fix patch task/unified-object-store #3 / 9
AI Agent gabriel · 115 days ago · May 21, 2026 · Diff

fix: update tests and impl for unified object store migration

- Update test helpers to use object_path instead of commit_path/snapshot_path - Fix _force_write_commit to write JSON+header to unified store (chmod read-only files before overwrite) - Fix _plant_commit_file to write stub directly to object_path bypassing hash verification - Fix blob_id test assertions to use sha256('blob <size>\0' + data) header format - Fix GC symlink warning: use skip_symlinks=False + manual check + logger.warning - Fix GC reachability: use canonical prefixed IDs (not bare hex) in reachable set - Fix snapshot_scale cache version assertion: 2 -> 3 - Fix mpack verify-pack: use fake_id() for missing snapshot IDs (not bare hex) - Fix write_snapshot: add assert_not_symlink guard on shard directory - Fix snapshot tests: use object_path/objects_dir/write_object; remove zstd-on-disk assumptions - Fix stdin+--write bare hex bug in hash-object: use read_object() to strip header - Fix fsync/mkstemp test assertions to match write_bytes (not atomic write) pattern - Fix bit-flip tests: use JSON-aware helpers to parse/repack unified object format - Fix commit.py: catch MissingParentError and retry with skip_parent_check=True

sha256:a61ac0eff73b2b1c688d3834a223075ebf069b20ac84b06d0f9833d7f88cb792 sha
sha256:64b7c97d15661242a344ee8ac332982768d3b97fb298d5f4c2d727eb1857ccbf parent
+9 ~120 −5 symbols
sha256:a6dbf4775df67d5dc8c7954fe48aa6ccc4183931b261293cc2bb06d613da2da8 snapshot
+9
symbols added
~120
symbols modified
−5
symbols removed
0
dead code introduced
Semantic Changes 134 symbols
~ muse/cli/commands/bridge.py .py 2 symbols modified
~ _replay_branch
~ run_hook
~ muse/cli/commands/commit.py .py 1 symbol added, 14 symbols modified
+ MissingParentError import import MissingParentError L53–53
~ CommitRecord
~ Manifest
~ Metadata
~ RefConflictError
~ SnapshotRecord
~ get_head_commit_id
~ get_head_snapshot_id
~ read_commit
~ read_current_branch
~ read_snapshot
~ write_branch_ref
~ write_commit
~ write_snapshot
~ run
~ muse/cli/commands/count_objects.py .py 1 symbol modified
~ _collect_reachable_ids
~ muse/cli/commands/hub/repos.py .py 1 symbol modified
~ run_repo_delete
~ muse/cli/commands/verify_object.py .py 1 symbol modified
~ _verify_one
~ muse/core/gc.py .py 1 symbol modified
~ _list_stored_objects
~ muse/core/store.py .py 1 symbol modified
~ write_snapshot
~ tests/test_cli_hub.py .py 2 symbols modified
~ TestHubRepoDeleteCommand
~ test_delete_json_output_emits_structured_result
~ tests/test_cmd_code_add.py .py 2 symbols modified
~ TestSecurityI
~ test_I12_snapshot_strips_muse_dir_entries_at_commit
~ tests/test_cmd_hash_object.py .py 2 symbols modified
~ TestWrite
~ test_write_creates_object_file
~ tests/test_cmd_invariants.py .py 1 symbol modified
~ _write_object
~ tests/test_cmd_reset_hardening.py .py 3 symbols modified
~ get_head_commit_id
~ read_current_branch
~ snapshot_path
~ tests/test_code_manifest.py .py 1 symbol modified
~ _write_object
~ tests/test_core_types.py .py 5 symbols modified
~ TestBlobId
~ test_empty_bytes
~ test_matches_manual_sha256
~ TestHashFile
~ test_matches_manual_sha256
~ tests/test_gc_path_helpers_and_remote_refs.py .py 2 symbols modified
~ TestPathHelpers
~ test_tags_dir_is_canonical
~ tests/test_gc_supercharge.py .py 2 symbols modified
~ TestGcJsonWarnings
~ test_symlink_snapshot_file_warning
~ tests/test_hash_object_canonical.py .py 1 symbol added, 3 symbols modified
+ read_object import import read_object L27–27
~ TestStdinWriteFixed
~ test_stdin_write_object_file_exists
~ object_path
~ tests/test_integrity_I10_bit_flip.py .py 2 symbols added, 2 symbols removed, 44 symbols modified
− commit_path import import commit_path L48–48
− snapshot_path import import snapshot_path L48–48
+ _parse_obj_payload function function _parse_obj_payload L108–112
+ _repack_obj_payload function function _repack_obj_payload L115–122
~ TestCommitBitFlip
~ test_commit_verify_critical_logged
~ test_core_field_committed_at_corruption_caught
~ test_core_field_message_corruption_caught
~ test_core_field_parent_id_corruption_caught
~ test_core_field_snapshot_id_corruption_caught
~ test_exhaustive_bits_in_core_positions_all_caught
~ test_metadata_field_branch_not_content_verified
~ TestCriticalLogged
~ test_commit_flip_emits_critical
~ test_snapshot_flip_emits_critical
~ TestMsgpackFuzz10k
~ test_5_bit_fuzz_10k_commit_core_field_always_touched
~ test_5_bit_fuzz_10k_snapshot_manifest_always_touched
~ TestObjectExhaustive4KiB
~ test_every_bit_in_32_byte_object
~ test_every_bit_in_4096_byte_object
~ TestRegressionSilentCorrupt
~ test_core_field_corruptions_zero_silent_passes
~ test_manifest_corruptions_zero_silent_passes
~ test_read_commit_returns_none_not_wrong_record
~ TestRoundTripIntegrity
~ test_commit_with_parents_round_trip
~ TestSnapshotBitFlip
~ test_created_at_not_content_verified
~ test_exhaustive_bits_in_manifest_region_all_caught
~ test_manifest_entry_deletion_caught
~ test_manifest_entry_injection_caught
~ test_manifest_oid_corruption_caught
~ test_manifest_path_corruption_caught
~ _make_commit
~ _make_snapshot
~ _repo
~ _stub_parent
~ CommitRecord
~ SnapshotRecord
~ _verify_commit_id
~ _verify_snapshot_id
~ read_commit
~ read_commit_result
~ read_snapshot
~ read_snapshot_result
~ write_commit
~ write_snapshot
~ tests/test_integrity_I2_fsync.py .py 1 symbol added, 1 symbol removed, 9 symbols modified
− test_no_orphan_in_store_after_replace_failure method method test_no_orphan_in_store_after_replace_failure L357–373
+ test_no_orphan_in_store_after_write_commit method method test_no_orphan_in_store_after_write_commit L334–339
~ TestFsyncCalledBeforeReplace
~ test_write_commit_calls_fsync_before_replace
~ TestNoOrphanTemps
~ TestRestoreObjectFsync
~ test_no_orphan_after_copy2_failure
~ TestUniqueTempNames
~ test_write_commit_uses_mkstemp
~ TestWriteObjectFromPathFsync
~ test_no_orphan_after_copy2_failure
~ tests/test_integrity_I6_snapshot_scale.py .py 2 symbols modified
~ TestCacheFormat
~ test_cache_file_is_msgpack
~ tests/test_mpack_cmd_verify.py .py 2 symbols modified
~ TestCommitConsistency
~ test_commit_missing_snapshot_fails
~ tests/test_phase2_parent_existence.py .py 1 symbol added, 2 symbols removed, 7 symbols modified
− commit_path import import commit_path L28–28
− msgpack import import msgpack L24–24
+ object_path import import object_path L27–27
~ TestMissingParentRejected
~ test_unknown_parent_produces_no_file
~ _plant_commit_file
~ CommitRecord
~ MissingParentError
~ commit_exists
~ write_commit
~ tests/test_snapshot_schema_version_and_compression.py .py 3 symbols added, 11 symbols modified
+ object_path import import object_path L47–47
+ objects_dir import import objects_dir L47–47
+ write_object import import write_object L47–47
~ TestBackwardCompat
~ test_old_uncompressed_snapshot_still_readable
~ TestCliCompression
~ test_cli_commit_writes_compressed_snapshot
~ TestCompressionRoundtrip
~ test_large_snapshot_on_disk_is_zstd_compressed
~ test_small_snapshot_on_disk_is_not_compressed
~ TestIntegrity
~ test_tampered_compressed_manifest_is_rejected
~ TestSecurity
~ test_symlinked_snapshot_dir_not_written
~ tests/test_verify_extended.py .py 1 symbol modified
~ _force_write_commit
Older test: migrate test suite to unified object store — replace compu… sha256:64b7c97d15661242a344ee8ac332982768d3b97fb298d5f4c2d727eb1857ccbf All commits Newer chore: zero typing_audit violations and untyped defs across muse… sha256:a42022a39e260112164a8b759ee1f9500593497253fdaabe7188baf32ffc7087

0 comments

No comments yet. Be the first to start the discussion.

To add a comment, use the Muse CLI: muse hub commit comment sha256:a61ac0eff73b2b1c688d3834a223075ebf069b20ac84b06d0f9833d7f88cb792 --body "your comment"