gabriel / muse public
refactor dev
AI Agent gabriel · 109 days ago · May 21, 2026 · Diff

refactor: delete dead _write_msgpack_atomic, rewrite symlink test for write_shelf_entry

_write_msgpack_atomic had no production callers after the JSON migration — deleted per the no-legacy policy. TestWriteMsgpackAtomicSymlink is replaced by TestWriteShelfEntrySymlink which covers the same symlink-swap attack vector on the active write_shelf_entry path.

sha256:ed0cdda7074e1836e426628a2658b977bb89f6c8c12f6608ec9bdf2bdef0e583 sha
sha256:38b4786f5f826527ae6d1b2bec7dec42107ebd568519ced86ae0fce7c05e73c1 parent
+5 ~1 −7 symbols
sha256:638cde80deb383e6bddcc2b25bcf87f092155e2367d7ec832accbbc00d2e9f27 snapshot
+5
symbols added
~1
symbol modified
−7
symbols removed
0
dead code introduced
Semantic Changes 13 symbols
~ muse/core/store.py .py 1 symbol removed
− _write_msgpack_atomic function function _write_msgpack_atomic L469–530
~ tests/test_security_symlink.py .py 5 symbols added, 6 symbols removed, 1 symbol modified
− TestWriteMsgpackAtomicSymlink class class TestWriteMsgpackAtomicSymlink L362–393
− _minimal_commit_dict method method _minimal_commit_dict L363–375
− test_normal_write_succeeds method method test_normal_write_succeeds L377–382
− test_symlinked_parent_raises method method test_symlinked_parent_raises L384–393
− CommitDict import import CommitDict L40–40
− _write_msgpack_atomic import import _write_msgpack_atomic L40–40
+ TestWriteShelfEntrySymlink class class TestWriteShelfEntrySymlink L362–388
+ _minimal_entry method method _minimal_entry L363–369
+ test_normal_write_succeeds method method test_normal_write_succeeds L371–376
+ test_symlinked_shelf_dir_raises method method test_symlinked_shelf_dir_raises L378–388
+ write_shelf_entry import import write_shelf_entry L40–40
~ write_text_atomic
← Older Oldest on dev
All commits
Newer → Latest on dev

0 comments

No comments yet. Be the first to start the discussion.

To add a comment, use the Muse CLI: muse hub commit comment sha256:ed0cdda7074e1836e426628a2658b977bb89f6c8c12f6608ec9bdf2bdef0e583 --body "your comment"