gabriel / muse public
fix patch task/mist-sign-hub-context #2 / 2
AI Agent gabriel · 61 days ago · Jul 6, 2026 · Diff

fix: thread hub context into muse mist create --sign (issue #75)

get_signing_identity() was called with zero arguments in run_create's signing block, so it could only resolve an identity when the caller's cwd happened to have a repo-local hub config — the --hub flag (already used correctly for --push) was never threaded into signing at all.

Resolves hub_url the same way --push does (hub_override, else repo-local config) and passes it as get_signing_identity(remote_url=...). Also warns on stderr when signing is requested but no hub context resolves at all, instead of silently returning signed=false.

Adds MISTSIGN_01-03 in tests/test_mist_cli.py exercising the real resolution path and asserting actual call arguments — existing coverage mocked get_signing_identity unconditionally and never observed this.

sha256:f7505032a4d5531c801c071fbd3f51880c7cb3d007077e724bbfd4c44277f586 sha
sha256:b7be56ec091919a612cffe7f3c8b600209d5155517443fdac0e16954c8c7d81f parent
+4 ~1 symbols
sha256:19e0b0e7f3fc944deefbb105f00fdd2f4c3170004a1d2210fb6de4b2a9681e11 snapshot
+4
symbols added
~1
symbol modified
0
dead code introduced
Semantic Changes 5 symbols
+ docs/
+ docs/guide/
+ docs/issues/
+ docs/mists/
+ docs/reference/
+ muse/
+ muse/cli/
+ muse/cli/commands/
+ muse/cli/commands/harmony/
+ muse/cli/commands/hub/
+ muse/core/
+ muse/core/bridge/
+ muse/core/crdts/
+ muse/core/diff_algorithms/
+ muse/core/harmony/
+ muse/core/plugins/
+ muse/plugins/
+ muse/plugins/code/
+ muse/plugins/identity/
+ muse/plugins/midi/
+ muse/plugins/mist/
+ muse/plugins/scaffold/
+ muse/plugins/social/
+ tests/
+ tests/fixtures/
+ tools/
~ muse/cli/commands/mist.py .py 1 symbol modified
~ run_create
~ tests/test_mist_cli.py .py 4 symbols added
+ TestMistSignHubContext class class TestMistSignHubContext L750–883
+ test_MISTSIGN_01_sign_succeeds_via_hub_flag_outside_repo_config method method test_MISTSIGN_01_sign_succeeds_via_hub_flag_outside_repo_config L763–817
+ test_MISTSIGN_02_get_signing_identity_called_with_resolved_hub method method test_MISTSIGN_02_get_signing_identity_called_with_resolved_hub L819–859
+ test_MISTSIGN_03_no_hub_context_warns_instead_of_silent method method test_MISTSIGN_03_no_hub_context_warns_instead_of_silent L861–883
← Older Oldest on task/mist-sign-hub-context
All commits Newer Merge branch 'dev' into task/mist-sign-hub-context sha256:0c90747ed271a81e4fd44dfe3fb111ab52fcd96050a4b3b16f262ed922269f31

0 comments

No comments yet. Be the first to start the discussion.

To add a comment, use the Muse CLI: muse hub commit comment sha256:f7505032a4d5531c801c071fbd3f51880c7cb3d007077e724bbfd4c44277f586 --body "your comment"