test_release_selection.py
python
sha256:c1e420ecafdcfabfd74f76e07d538ec0c884be32b14f6062d32cb19690a3d4d3
test(release): red tests for artifact immutability, retenti…
Opus 5.5
12 days ago
| 1 | """Deterministic release selection (musehub#114 Phase 6). |
| 2 | |
| 3 | The served installer is chosen by the instance's ``active.json`` pointer -- an |
| 4 | explicit version + SHA-256 -- never by filesystem mtime. These tests prove that |
| 5 | copying, touching or restoring older tarballs cannot change what is served, and |
| 6 | that inconsistent state is an error rather than a guess. |
| 7 | """ |
| 8 | |
| 9 | from __future__ import annotations |
| 10 | |
| 11 | import hashlib |
| 12 | import json |
| 13 | import os |
| 14 | import pathlib |
| 15 | |
| 16 | import pytest |
| 17 | |
| 18 | from musehub.config import settings |
| 19 | from musehub.release_pointer import ReleaseSelectionError, resolve_active_release |
| 20 | |
| 21 | |
| 22 | def _sha(data: bytes) -> str: |
| 23 | return hashlib.sha256(data).hexdigest() |
| 24 | |
| 25 | |
| 26 | def _put_release(releases: pathlib.Path, version: str, data: bytes | None = None) -> str: |
| 27 | body = data if data is not None else f"sdist {version}".encode() |
| 28 | (releases / f"muse-{version}.tar.gz").write_bytes(body) |
| 29 | return _sha(body) |
| 30 | |
| 31 | |
| 32 | def _point(releases: pathlib.Path, version: str, sha: str, env: str = "staging") -> None: |
| 33 | (releases / "active.json").write_text(json.dumps({ |
| 34 | "schema": 1, "environment": env, "version": version, "sha256": sha, |
| 35 | "previous": None, "activated_at": "2026-11-03T12:00:00+00:00", |
| 36 | })) |
| 37 | |
| 38 | |
| 39 | @pytest.fixture |
| 40 | def releases(tmp_path: pathlib.Path, monkeypatch: pytest.MonkeyPatch) -> pathlib.Path: |
| 41 | d = tmp_path / "rel" |
| 42 | d.mkdir() |
| 43 | monkeypatch.setattr(settings, "musehub_releases_dir", str(d)) |
| 44 | return d |
| 45 | |
| 46 | |
| 47 | class TestResolveActiveRelease: |
| 48 | def test_pointer_names_the_release(self, releases: pathlib.Path) -> None: |
| 49 | _put_release(releases, "0.2.1rc18") |
| 50 | _point(releases, "0.2.1rc19", _put_release(releases, "0.2.1rc19")) |
| 51 | assert resolve_active_release(releases).version == "0.2.1rc19" |
| 52 | |
| 53 | def test_touching_an_older_tarball_cannot_change_the_selection(self, releases: pathlib.Path) -> None: |
| 54 | _put_release(releases, "0.2.1rc18") |
| 55 | _point(releases, "0.2.1rc19", _put_release(releases, "0.2.1rc19")) |
| 56 | future = releases.stat().st_mtime + 10_000 |
| 57 | os.utime(releases / "muse-0.2.1rc18.tar.gz", (future, future)) |
| 58 | assert resolve_active_release(releases).version == "0.2.1rc19" |
| 59 | |
| 60 | def test_copying_an_older_tarball_in_afresh_cannot_change_the_selection(self, releases: pathlib.Path) -> None: |
| 61 | _point(releases, "0.2.1rc19", _put_release(releases, "0.2.1rc19")) |
| 62 | _put_release(releases, "0.2.1rc16") # restored later => newest mtime |
| 63 | assert resolve_active_release(releases).version == "0.2.1rc19" |
| 64 | |
| 65 | def test_a_higher_pep440_version_on_disk_is_not_selected_implicitly(self, releases: pathlib.Path) -> None: |
| 66 | _point(releases, "0.2.1rc19", _put_release(releases, "0.2.1rc19")) |
| 67 | _put_release(releases, "0.3.0") |
| 68 | assert resolve_active_release(releases).version == "0.2.1rc19" |
| 69 | |
| 70 | def test_rewriting_the_selected_tarball_with_other_bytes_is_detected(self, releases: pathlib.Path) -> None: |
| 71 | _point(releases, "0.2.1rc19", _put_release(releases, "0.2.1rc19")) |
| 72 | (releases / "muse-0.2.1rc19.tar.gz").write_bytes(b"swapped") |
| 73 | with pytest.raises(ReleaseSelectionError, match="sha256"): |
| 74 | resolve_active_release(releases) |
| 75 | |
| 76 | def test_rollback_is_just_a_pointer_to_a_known_version_and_hash(self, releases: pathlib.Path) -> None: |
| 77 | sha18 = _put_release(releases, "0.2.1rc18") |
| 78 | _put_release(releases, "0.2.1rc19") |
| 79 | _point(releases, "0.2.1rc18", sha18) |
| 80 | assert resolve_active_release(releases).version == "0.2.1rc18" |
| 81 | |
| 82 | @pytest.mark.parametrize("content", [ |
| 83 | None, "", "not json", "[]", '{"schema": 1}', |
| 84 | '{"schema": 9, "environment": "staging", "version": "1", "sha256": "' + "0" * 64 + '"}', |
| 85 | '{"schema": 1, "environment": "staging", "version": "../x", "sha256": "' + "0" * 64 + '"}', |
| 86 | '{"schema": 1, "environment": "staging", "version": "0.2.1rc19", "sha256": "short"}', |
| 87 | ]) |
| 88 | def test_missing_or_malformed_pointer_is_an_error_not_a_guess(self, releases: pathlib.Path, content: str | None) -> None: |
| 89 | _put_release(releases, "0.2.1rc19") |
| 90 | if content is not None: |
| 91 | (releases / "active.json").write_text(content) |
| 92 | with pytest.raises(ReleaseSelectionError): |
| 93 | resolve_active_release(releases) |
| 94 | |
| 95 | def test_pointer_to_a_missing_tarball_is_an_error(self, releases: pathlib.Path) -> None: |
| 96 | _point(releases, "0.2.1rc19", "0" * 64) |
| 97 | with pytest.raises(ReleaseSelectionError, match="missing"): |
| 98 | resolve_active_release(releases) |
| 99 | |
| 100 | |
| 101 | class TestInstallScriptUsesThePointer: |
| 102 | def test_default_install_script_embeds_the_pointed_version(self, releases: pathlib.Path) -> None: |
| 103 | from musehub.api.routes.musehub.install import generate_install_script |
| 104 | |
| 105 | _put_release(releases, "0.2.1rc18") |
| 106 | _point(releases, "0.2.1rc19", _put_release(releases, "0.2.1rc19")) |
| 107 | future = releases.stat().st_mtime + 10_000 |
| 108 | os.utime(releases / "muse-0.2.1rc18.tar.gz", (future, future)) |
| 109 | script = generate_install_script("https://staging.musehub.ai") |
| 110 | assert 'MUSE_VERSION="0.2.1rc19"' in script or "0.2.1rc19" in script |
| 111 | assert "0.2.1rc18" not in script |
| 112 | |
| 113 | def test_explicit_version_is_authoritative(self, releases: pathlib.Path) -> None: |
| 114 | from musehub.api.routes.musehub.install import generate_install_script |
| 115 | |
| 116 | _point(releases, "0.2.1rc19", _put_release(releases, "0.2.1rc19")) |
| 117 | assert "0.2.1rc18" in generate_install_script("https://staging.musehub.ai", "0.2.1rc18") |
| 118 | |
| 119 | async def test_endpoint_fails_closed_without_a_pointer(self, releases: pathlib.Path, client) -> None: # type: ignore[no-untyped-def] |
| 120 | _put_release(releases, "0.2.1rc19") |
| 121 | resp = await client.get("/install.sh") |
| 122 | assert resp.status_code == 503 |
| 123 | assert "rc19" not in resp.text |
File History
1 commit
sha256:c1e420ecafdcfabfd74f76e07d538ec0c884be32b14f6062d32cb19690a3d4d3
test(release): red tests for artifact immutability, retenti…
Opus 5.5
12 days ago