gabriel / musehub public
fix patch main #18 / 34
AI Agent gabriel · 126 days ago · May 9, 2026 · Diff

fix: handle top-level symbol ops in proposal delta (no child_ops wrapper)

Real Muse structured_deltas emit symbol ops directly in ops[] — not only inside child_ops of a parent patch/replace op. The service was only scanning child_ops so proposals with direct symbol ops returned an empty delta.

Fix: for each top-level op, collect [top_op] + child_ops into a candidates list and filter by '::' in address. Both shapes now produce entries.

Also adds two regression tests: test_top_level_symbol_op_no_parent_wrapper test_mixed_top_level_and_child_ops

sha256:5350285dd2dc94d5607cd09c62f02791c1068fc6eb075c24a22b163e5f667515 sha
sha256:08eef1d16ea75ed14f33ab731be517c9a33517eda401b28349a6b9c53708ff3d parent
+2 ~1 symbols
sha256:94919f3a07d8147fd4034aad23b0708ffa8cb395fbe350e6aaecaf51a6a11447 snapshot
+2
symbols added
~1
symbol modified
0
dead code introduced
Semantic Changes 3 symbols
~ musehub/services/proposal_symbol_delta.py .py 1 symbol modified
~ build_proposal_symbol_delta
~ tests/test_proposal_symbol_delta.py .py 2 symbols added
+ test_mixed_top_level_and_child_ops function function test_mixed_top_level_and_child_ops L433–455
+ test_top_level_symbol_op_no_parent_wrapper function function test_top_level_symbol_op_no_parent_wrapper L411–430
Older fix: update MergeStrategy test to include cherry_pick value sha256:c29b73516f93bd90fb68f49d30b18c05a0dba5d7011c574faa3288c4f0800560 All commits Newer feat: cross-repo and ref-pinned symbol anchors sha256:fc451e2dc8f414c220717efbc79cbb5dcacd39f8fa131fa068ba62a7399687a4

0 comments

No comments yet. Be the first to start the discussion.

To add a comment, use the Muse CLI: muse hub commit comment sha256:5350285dd2dc94d5607cd09c62f02791c1068fc6eb075c24a22b163e5f667515 --body "your comment"