gabriel / musehub public
fix BREAKING dev
AI Agent gabriel · 142 days ago · May 2, 2026 · Diff

fix: activity canvas — use domain_id plain string, null defaults to code

Drop the musehub_domains JOIN from build_activity_canvas and _fetch_repos. domain_id in musehub_repos is a plain string label ("code", "midi", "mist") or NULL for legacy repos. NULL is treated as "code" throughout.

- musehub_profile.py: drop musehub_domain_models import; rewrite build_activity_canvas to query distinct domain_id directly; update _build_domain_commit_grid to match null repos under "code" - ui_user_profile.py: drop MusehubDomain join in _fetch_repos, use r.domain_id or "code" directly - Tests updated to use plain string domain_ids; phantom data-domain template tests removed (attribute never existed in profile.html)

sha256:98310689f8864e4e6adabd679d6e1f170bfe11deadac1912945df5dc6bec5dda sha
sha256:cc8a1fca8238f7b766bda367493a449e07ede92d5521fdcd1f817f579b78c1c9 parent
+1 ~14 −8 symbols
sha256:7255962e1623ce27e128ec2c6128f0b53056f1922741d247edc27e58557a07d8 snapshot
+1
symbol added
~14
symbols modified
−8
symbols removed
0
dead code introduced
Semantic Changes 23 symbols
~ musehub/api/routes/musehub/ui_user_profile.py .py 1 symbol modified
~ _fetch_repos
~ musehub/services/musehub_profile.py .py 1 symbol removed, 3 symbols modified
− domain_db import import domain_db L16–16
~ _build_domain_commit_grid
~ build_activity_canvas
~ get_public_repos
~ tests/test_generic_domain.py .py 3 symbols removed
− test_profile_chip_generic_domain_has_distinct_icon function async_function test_profile_chip_generic_domain_has_distinct_icon L228–271
− test_profile_html_no_domain_id_shows_generic_chip function async_function test_profile_html_no_domain_id_shows_generic_chip L141–173
− test_profile_html_with_domain_id_does_not_show_generic function async_function test_profile_html_with_domain_id_does_not_show_generic L177–219
~ tests/test_mist_phase5_profile_canvas.py .py 4 symbols removed, 8 symbols modified
− _ensure_domain function async_function _ensure_domain L44–62
− _repo_id function function _repo_id L40–41
− compute_domain_id import import compute_domain_id L29–29
− dm import import dm L28–28
~ TestBuildMistVcsGrid
~ test_domain_commit_grid_counts_only_target_domain
~ TestMistCanvasRegression
~ test_mist_and_code_both_shown_when_active
~ _seed_mist_repo_no_commits
~ _seed_mist_repo_with_commits
~ compute_identity_id
~ compute_repo_id
~ tests/test_musehub_profile_service.py .py 1 symbol added, 2 symbols modified
+ test_canvas_null_domain_id_counts_as_code function async_function test_canvas_null_domain_id_counts_as_code L248–275
~ test_canvas_shows_only_domains_with_commits
~ test_get_public_repos_preserves_explicit_domain
← Older Oldest on dev
All commits
Newer → Latest on dev

0 comments

No comments yet. Be the first to start the discussion.

To add a comment, use the Muse CLI: muse hub commit comment sha256:98310689f8864e4e6adabd679d6e1f170bfe11deadac1912945df5dc6bec5dda --body "your comment"