gabriel / musehub public
fix patch fix/test-suite-real-bugs #1 / 1
AI Agent gabriel · 1 day ago · Sep 7, 2026 · Diff

fix: ran full test suite for real, fixed 2 genuine bugs found (#164/#165/#166/#167)

Ran the actual 7028-test suite (previously only confirmed it collects) - 7003 passed, 15 failed, 24 skipped. Root-caused and fixed 9 of 15: test_repo_card_e2e.py's _attach_repo_to_domain helper set the wrong column (domain_id, an unrelated VCS-plugin category string) instead of marketplace_domain_id, the actual repo<->marketplace-domain link - musehub_domains.list_repos_for_domain's own docstring warns about exactly this confusion. Application code was never wrong, only the test fixture.

Also fixed test_only_safe_env_vars_in_dockerfile - PLAYWRIGHT_BROWSERS_PATH (needed at build time for the OG-card Chromium install, #129) was never added to the approved safe-var list. Not a secret, just a path.

Remaining 5 failures (test_opengraph_repo_cards.py) are a test-environment gap, not a code bug - they need a configured blob storage backend that isn't set up here. Not fixed in this pass.

Re-verified Sections 16-19 against current reality: most of what this doc originally called blocked is now resolved elsewhere (backups, Aaron's independent access, DNS/TLS, prod deploy). Confirmed canonical redirects and external TLS live via curl/openssl. Confirmed the maintainer-SPOF test now passes. Noted production cutover already happened (2026-08-25) - this doc should read retrospectively for Section 18, not as forward planning.

sha256:a8286b6512e38543c4311a60e5db187a9d4d3737413e77a833f71502665880cf sha
sha256:4a3bec765a9b2ed6f748a19df69a1e7a72ed157e59db2d13bb9bef3d67b68f97 parent
+2 ~8 symbols
3 changed · 1060 in snapshot files
sha256:6e6e5c200e806f5f91072daa575fa53cc4091ef3dba9f0ef0b32b504b361afe7 snapshot
+2
symbols added
~8
symbols modified
3
files changed
1060
files in snapshot
0
dead code introduced
Semantic Changes 10 symbols
+ .vscode/
+ alembic/
+ alembic/versions/
+ deploy/
+ deploy/load-tests/
+ docs/
+ docs/architecture/
+ docs/guides/
+ docs/issues/
+ docs/issues/assets/
+ docs/legal/
+ docs/mists/
+ docs/production-readiness/
+ docs/reference/
+ docs/releases/
+ docs/roadmaps/
+ musehub/
+ musehub/api/
+ musehub/api/routes/
+ musehub/api/routes/api/
+ musehub/api/routes/musehub/
+ musehub/auth/
+ musehub/core/
+ musehub/crypto/
+ musehub/db/
+ musehub/debug/
+ musehub/graph/
+ musehub/maintenance/
+ musehub/mcp/
+ musehub/mcp/tools/
+ musehub/mcp/write_tools/
+ musehub/middleware/
+ musehub/models/
+ musehub/muse_cli/
+ musehub/proposals/
+ musehub/protocol/
+ musehub/security/
+ musehub/services/
+ musehub/storage/
+ musehub/templates/
+ musehub/templates/mcp/
+ musehub/templates/musehub/
+ musehub/templates/musehub/fragments/
+ musehub/templates/musehub/macros/
+ musehub/templates/musehub/opengraph/
+ musehub/templates/musehub/pages/
+ musehub/templates/musehub/partials/
+ musehub/templates/musehub/static/
+ musehub/templates/musehub/static/vendor/
+ musehub/types/
+ scripts/
+ src/
+ src/scss/
+ src/scss/components/
+ src/scss/pages/
+ src/scss/patterns/
+ src/scss/theme/
+ src/ts/
+ src/ts/pages/
+ tests/
+ tests/unit/
+ tools/
+ workflows/
~ docs/production-readiness/16-19-docs-testing-cutover-postlaunch.md .md 2 symbols added, 5 symbols modified
+ code variable variable code L48–51
+ Update (2026-09-07) — most blockers resolved elsewhere; two real bugs found and fixed section Update (2026-09-07) — most blockers resolved elsewhere; two real bugs found and fixed L5–13
~ Sections 16–19 — Documentation, Testing, Cutover, Post-Launch
~ Section 16 — Documentation and Runbooks
~ Section 17 — Testing Before Launch
~ Section 18 — Cutover Plan
~ Section 19 — Post-Launch
~ tests/test_repo_card_e2e.py .py 1 symbol modified
~ _attach_repo_to_domain
~ tests/test_secrets_management.py .py 2 symbols modified
~ TestDockerImageLayers
~ test_only_safe_env_vars_in_dockerfile
Files Changed
~3
1060 in snapshot
~ docs/production-readiness/16-19-docs-testing-cutover-postlaunch.md .md
~ tests/test_repo_card_e2e.py .py
~ tests/test_secrets_management.py .py
← Older Oldest on fix/test-suite-real-bugs
All commits
Newer → Latest on fix/test-suite-real-bugs

0 comments

No comments yet. Be the first to start the discussion.

To add a comment, use the Muse CLI: muse hub commit comment sha256:a8286b6512e38543c4311a60e5db187a9d4d3737413e77a833f71502665880cf --body "your comment"