gabriel / musehub public
fix BREAKING task/typing-audit #3 / 4
AI Agent gabriel · 166 days ago · Apr 12, 2026 · Diff

fix: typing audit — zero violations across all test files

- Define TypedDicts for structured payloads (SymbolEntry, Delta, S3Response, wire object payloads) - Replace param/return object with concrete unions and named type aliases - Replace dict[str, Any]/dict[str, object] with JSONObject, StrDict, or TypedDicts - Remove local variable annotations that triggered boundary_dict - Fix type: ignore comments by asserting non-None or using setattr - Extend typing_audit to emit file:line violations in human output

sha256:ca71d97bba51f0af457c8c984011b1d2f40c422e31112ad7286fc9d4f0121d72 sha
sha256:e883dee62e36af28206c3fb06d64a8095ecb6a5e152511dedb2454529569060d parent
+20 ~34 −2 symbols
sha256:666c627e6ef465794a36ceca7fd1aaac8f182e1ddaddae27d44e225f6b2b2518 snapshot
+20
symbols added
~34
symbols modified
−2
symbols removed
0
dead code introduced
Semantic Changes 56 symbols
~ tests/conftest.py .py 1 symbol added, 1 symbol modified
+ _JobPayload variable variable _JobPayload L36–36
~ _stub_push_background_tasks
~ tests/test_background_jobs.py .py 2 symbols added, 2 symbols modified
+ _MsgpackInput variable variable _MsgpackInput L32–32
+ StrDict import import StrDict L29–29
~ _mp
~ test_push_enqueues_symbol_index_and_gc_jobs
~ tests/test_musehub_issues_input_limits.py .py 1 symbol modified
~ _create_issue
~ tests/test_musehub_pagination.py .py 1 symbol added, 1 symbol modified
+ _IssueJson variable variable _IssueJson L20–20
~ _create_issue
~ tests/test_musehub_proposals_touched_symbols.py .py 4 symbols added, 1 symbol removed, 2 symbols modified
− Any import import Any L16–16
+ _ChildOp class class _ChildOp L41–44
+ _Delta class class _Delta L52–53
+ _DeltaOp class class _DeltaOp L47–49
+ TypedDict import import TypedDict L16–16
~ _delta
~ _make_commit
~ tests/test_musehub_ui_blob_deep_links.py .py 1 symbol added, 10 symbols modified
+ JSONObject import import JSONObject L33–33
~ StrDict
~ test_enrich_adds_lineno_for_class
~ test_enrich_adds_lineno_for_known_function
~ test_enrich_does_not_overwrite_existing_lineno
~ test_enrich_ignores_symbol_not_in_ast
~ test_enrich_skips_non_python_files
~ test_enrich_tolerates_syntax_error
~ test_symbol_line_map_excludes_falsy_lineno
~ test_symbol_line_map_excludes_symbols_without_lineno
~ test_symbol_line_map_returns_display_name_to_lineno
~ tests/test_pagination_section39.py .py 1 symbol added, 1 symbol modified
+ _IssueJson variable variable _IssueJson L35–35
~ _create_issue
~ tests/test_perf_push_pipeline.py .py 2 symbols added, 3 symbols modified
+ _MsgpackInput variable variable _MsgpackInput L40–40
+ StrDict import import StrDict L37–37
~ _make_snapshots
~ _mp
~ test_symbol_indexer_large_push_does_not_crash
~ tests/test_snapshot_symbol_indexer.py .py 2 symbols modified
~ TestPerSymbolIntelBackfill
~ test_author_count_reflects_unique_authors
~ tests/test_storage_backends_section33.py .py 2 symbols added, 1 symbol removed, 3 symbols modified
− Any import import Any L37–37
+ _S3GetResponse class class _S3GetResponse L48–49
+ TypedDict import import TypedDict L37–37
~ TestIntegrationS3BackendMocked
~ test_get_batch_is_parallel_not_sequential
~ test_get_batch_returns_all_found_objects
~ tests/test_wire_compression.py .py 5 symbols added, 4 symbols modified
+ _DeltaObjectPayload class class _DeltaObjectPayload L50–55
+ _MsgpackInput variable variable _MsgpackInput L33–33
+ _RawObjectPayload class class _RawObjectPayload L36–40
+ _ZlibObjectPayload class class _ZlibObjectPayload L43–47
+ TypedDict import import TypedDict L28–28
~ _make_delta_object
~ _make_raw_object
~ _make_zlib_object
~ _mp
~ tests/test_wire_protocol.py .py 1 symbol modified
~ test_bulk_upsert_snapshot_entries_skips_existing
~ tools/typing_audit.py .py 1 symbol added, 3 symbols modified
+ Violation class class Violation L75–80
~ Report
~ generate_report
~ print_human_summary
Older feat: add fork visibility, guard private repos, fix default visi… sha256:e883dee62e36af28206c3fb06d64a8095ecb6a5e152511dedb2454529569060d All commits Newer tooling: add gen_type_contracts.py and regenerate type-contracts.md sha256:7415b278906587d150233f06c69d5040dec0fc33140b72ccad39dc02ebc3f286

0 comments

No comments yet. Be the first to start the discussion.

To add a comment, use the Muse CLI: muse hub commit comment sha256:ca71d97bba51f0af457c8c984011b1d2f40c422e31112ad7286fc9d4f0121d72 --body "your comment"