test(wire-fetch): RED — fail closed when a required blob is unrecoverable; keep valid empty blobs
wire_fetch_mpack logs a warning and still builds, uploads and caches an mpack that lacks blobs no store could supply, and drops empty blobs (truthiness checks) as if they were missing. Pins: an unrecoverable required blob raises FetchBlobsUnavailableError before build/upload/cache; valid empty blobs stay in the mpack whether they come from the index or the per-object store.
sha256:cff6528dd110d59db8e460aaf29c3677f27dce5fedc4ccfde4f2bbeea37efa25
sha
+6
symbols
sha256:05bf2723eb75a380206e2388662634ef37ec8ec7fce3b734caf6ffcc793e0ab7
snapshot
+6
symbols added
0
dead code introduced
Semantic Changes
6 symbols
+
test_empty_blob_resolved_from_per_object_store_is_kept
function
async_function test_empty_blob_resolved_from_per_object_store_is_kept L220–240
+
test_every_unrecoverable_blob_is_counted
function
async_function test_every_unrecoverable_blob_is_counted L181–196
+
test_unrecoverable_blob_fails_before_build_upload_or_cache
function
async_function test_unrecoverable_blob_fails_before_build_upload_or_cache L156–177
+
test_valid_empty_blob_is_kept_in_the_built_mpack
function
async_function test_valid_empty_blob_is_kept_in_the_built_mpack L200–216
← Older
Oldest on task/mpack-fail-closed
All commits
Newer
fix(wire-fetch): fail closed when a required blob is unrecoverab…
sha256:3aaa46c8fe7e63f87860fa02ce1d50fab32561de42edad921668b967803dabc1
0 comments
To add a comment, use the Muse CLI:
muse hub commit comment sha256:cff6528dd110d59db8e460aaf29c3677f27dce5fedc4ccfde4f2bbeea37efa25 --body "your comment"
No comments yet. Be the first to start the discussion.