gabriel / muse public
fix dev
AI Agent gabriel · 109 days ago · May 21, 2026 · Diff

fix: remove stale msgpack references from tests (batch 5)

Replace msgpack with JSON in test fixtures and roundtrip helpers that touch storage paths: test history serialization, shelf entry writers, gc tests, snapshot delta size comparison, snapshot schema/compression docstrings, and fsync enospc test suite cleanup after _write_msgpack_atomic deletion.

Fix _force_write_tag to write JSON to .json path — previously writing msgpack bytes to a .json file made tags unreadable (tests passed vacuously because _read_tag_or_migrate swallowed the parse error and returned None).

sha256:f7f63fc0ed7f18d4b6e73b3735c57deeeabe72132c5af5fbabd41ec0b3811012 sha
sha256:ed0cdda7074e1836e426628a2658b977bb89f6c8c12f6608ec9bdf2bdef0e583 parent
+3 ~26 −28 symbols
sha256:a1073dadb035f45506bda83e8c2837400e903928e1477afb26b0efe7eb5009cc snapshot
+3
symbols added
~26
symbols modified
−28
symbols removed
0
dead code introduced
Semantic Changes 57 symbols
~ tests/test_cmd_verify_tag.py .py 1 symbol modified
~ _force_write_tag
~ tests/test_core_gc.py .py 1 symbol added, 1 symbol removed, 5 symbols modified
− msgpack import import msgpack L9–9
+ write_shelf_entry import import write_shelf_entry L13–13
~ _write_shelf_entry
~ CommitRecord
~ SnapshotRecord
~ write_commit
~ write_snapshot
~ tests/test_core_test_history.py .py 4 symbols modified
~ TestRecordSerialization
~ test_longrepr_round_trip
~ test_none_fields_preserved
~ test_round_trip
~ tests/test_gc_corrupt_commit_object_retention.py .py 1 symbol removed
− msgpack import import msgpack L51–51
~ tests/test_object_store_write_taxonomy.py .py 1 symbol added, 1 symbol removed, 5 symbols modified
− msgpack import import msgpack L46–46
+ write_shelf_entry import import write_shelf_entry L60–60
~ _write_shelf_entry
~ CommitRecord
~ SnapshotRecord
~ write_commit
~ write_snapshot
~ tests/test_security_object_store_poisoning.py .py 2 symbols modified
~ TestCallsiteIntegrity
~ test_unpack_objects_hash_mismatch_rejected
~ tests/test_snapshot_delta.py .py 1 symbol modified
~ test_delta_smaller_than_full_for_typical_commit
~ tests/test_snapshot_schema_version_and_compression.py .py 1 symbol added, 1 symbol removed, 4 symbols modified
− msgpack import import msgpack L34–34
+ _json import import _json L34–34
~ TestSchemaVersionField
~ test_from_dict_defaults_schema_version_for_old_files
~ TestZstdHelpers
~ test_decompress_noop_on_plain_bytes
~ tests/test_store_fsync_enospc.py .py 24 symbols removed, 3 symbols modified
− test_write_msgpack_atomic_enospc_exception_propagates_to_caller method method test_write_msgpack_atomic_enospc_exception_propagates_to_caller L415–427
− test_500_msgpack_writes_complete_under_5s method method test_500_msgpack_writes_complete_under_5s L737–748
− test_write_msgpack_atomic_einval_suppressed method method test_write_msgpack_atomic_einval_suppressed L692–698
− TestWriteMsgpackAtomicDarwin class class TestWriteMsgpackAtomicDarwin L335–387
− _call method method _call L338–343
− test_f_barrierfsync_einval_falls_through_fsync_enospc_raises method method test_f_barrierfsync_einval_falls_through_fsync_enospc_raises L377–387
− test_f_barrierfsync_einval_falls_through_to_fsync_einval_suppressed method method test_f_barrierfsync_einval_falls_through_to_fsync_einval_suppressed L367–375
− test_f_barrierfsync_enospc_and_fsync_enospc_raises method method test_f_barrierfsync_enospc_and_fsync_enospc_raises L358–365
− test_f_barrierfsync_enospc_fallthrough_fsync_succeeds method method test_f_barrierfsync_enospc_fallthrough_fsync_succeeds L345–356
− TestWriteMsgpackAtomicFsync class class TestWriteMsgpackAtomicFsync L206–326
− _call method method _call L217–222
− _make_record method method _make_record L209–215
− _patch_fsync_einval method method _patch_fsync_einval L267–284
− _patch_fsync_eio method method _patch_fsync_eio L248–265
− _patch_fsync_enospc method method _patch_fsync_enospc L224–246
− test_einval_suppressed method method test_einval_suppressed L300–304
− test_eio_raises method method test_eio_raises L293–298
− test_enospc_does_not_create_target method method test_enospc_does_not_create_target L314–321
− test_enospc_leaves_no_temp_files method method test_enospc_leaves_no_temp_files L306–312
− test_enospc_raises method method test_enospc_raises L286–291
− test_successful_write_still_works method method test_successful_write_still_works L323–326
− _patch_msgpack_sync function function _patch_msgpack_sync L75–100
− AbstractContextManager import import AbstractContextManager L51–51
− Generator import import Generator L50–50
~ TestDataIntegrityOnEnospc
~ TestPerformanceNormalPath
~ TestRegressionEinvalSuppressed
~ tests/test_verify_tag_supercharge.py .py 1 symbol modified
~ _force_write_tag
← Older Oldest on dev
All commits
Newer → Latest on dev

0 comments

No comments yet. Be the first to start the discussion.

To add a comment, use the Muse CLI: muse hub commit comment sha256:f7f63fc0ed7f18d4b6e73b3735c57deeeabe72132c5af5fbabd41ec0b3811012 --body "your comment"